Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StdLib): Go v0.0.1 release #1195

Merged
merged 7 commits into from
Jan 13, 2025
Merged

feat(StdLib): Go v0.0.1 release #1195

merged 7 commits into from
Jan 13, 2025

Conversation

ShubhamChaturvedi7
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 commented Jan 10, 2025 •
edited
Loading

Issue #, if available:

Description of changes:

Initial release based on MPL 1.8.0.

Files to be reviewed:
README.md
LICENSE
CHANGELOG.md
externs (Copied over from checked-in code / Optional)
Makefile (Copied over from checked-in code / Optional)
go.mod (Copied over from checked-in code / Optional)

Other files are polymorphed files.
Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ShubhamChaturvedi7 ShubhamChaturvedi7 requested a review from a team as a code owner January 10, 2025 21:54
@ShubhamChaturvedi7 ShubhamChaturvedi7 changed the title release(StdLib): v0.0.1 feat(StdLib): Go v0.0.1 release Jan 10, 2025
seebees
seebees previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishav-karanjit
Copy link
Member

rishav-karanjit commented Jan 13, 2025 •
edited
Loading

Some overall things:

  1. Can we have a MCM to see how this fits in?
  2. How do we know if this code runs as it ran when it was inside runtime/go? Knowing this before releasing would help MCM technician/requester.
  3. What tag are we adding to do this release?

@ShubhamChaturvedi7 @rishav-karanjit
Update releases/go/smithy-dafny-standard-library/go.mod
682c9db 
Co-authored-by: Rishav karanjit <karanjitrishav4@gmail.com>
@ShubhamChaturvedi7
Copy link
Contributor Author

Some overall things:

1. Can we have a MCM to see how this fits in?

2. How do we know if this code runs as it ran when it was inside runtime/go? Knowing this before releasing would help MCM technician/requester?

3. What tag are we adding to do this release?

MCM is answered here: https://amzn-aws.slack.com/archives/G01813NHQBD/p1736791637977939?thread_ts=1736559063.433249&cid=G01813NHQBD

  1. MCM is planned later after this release. It'd be futile to have an MCM which doesn't cover all the steps and we are still discovering the steps.
  2. Ran go build
  3. Mentioned in the description v0.0.1

@rishav-karanjit
Copy link
Member

Mentioned in the description v0.0.1

Shouldn't it be prefixed with path from the runtime?
ref: https://go.dev/ref/mod#vcs-version

If a module is defined in a subdirectory within the repository, that is, the module subdirectory portion of the module path is not empty, then each tag name must be prefixed with the module subdirectory, followed by a slash.

rishav-karanjit
rishav-karanjit approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@rishav-karanjit rishav-karanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline. The GitHub tag is prefixed with subdirectories.

Non blocking but it could be great if we could have a CI test to do go build to check if the copied code works correctly.

LGTM

@ShubhamChaturvedi7
Copy link
Contributor Author

Mentioned in the description v0.0.1

Shouldn't it be prefixed with path from the runtime? ref: https://go.dev/ref/mod#vcs-version

If a module is defined in a subdirectory within the repository, that is, the module subdirectory portion of the module path is not empty, then each tag name must be prefixed with the module subdirectory, followed by a slash.

Are you talking about git tag or Go tag? The git tag would be something like git tag smithy-dafny-standard-library/v0.0.1-alpha (in this case releases/go will be prefixed as well), and go version tag v0.0.1 so that users can do go get X@v0.0.1.

Here's an example to explain this: https://github.com/ShubhamChaturvedi7/aws-cryptographic-material-providers-library-go/releases/tag/smithy-dafny-standard-library%2Fv0.0.1-alpha

@ShubhamChaturvedi7 ShubhamChaturvedi7 merged commit 95e54bf into main Jan 13, 2025
168 checks passed
RitvikKapila pushed a commit that referenced this pull request Jan 31, 2025
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
51ccca1 
# [1.9.0](v1.8.0...v1.9.0) (2025-01-31)

### Bug Fixes

* CI ([d9e2a1e](d9e2a1e))
* DafnyLibraries.FileIO extern ([b150c48](b150c48))
* ECDH ValidatePublicKey err msg ([34a48fc](34a48fc))
* for test vectors, use SetToSequenceSorted ([#1034](#1034)) ([21ad206](21ad206))
* **GHW:** check-files apply to PR, not to diff b/w HEAD and branch ([#1075](#1075)) ([1f53a92](1f53a92))
* improve golang externs ([#1133](#1133)) ([b6ee16e](b6ee16e))
* **Java:** Improve Collection of Errors string ([#1056](#1056)) ([9e195a1](9e195a1))
* line breaks ([21536c7](21536c7))
* PR comments ([798214b](798214b))
* PR comments ([a21c0b3](a21c0b3))
* PR comments ([7dd95bc](7dd95bc))
* PR comments ([eed0d87](eed0d87))
* PR comments ([435515e](435515e))
* re-enable aes_gcm_192 ([#1143](#1143)) ([23650a9](23650a9))
* region ([5930ae4](5930ae4))
* region ([e3454b5](e3454b5))
* remove [@sensitive](https://github.com/sensitive) from smithy models ([#1123](#1123)) ([c939f3a](c939f3a))
* repo rename ([#1218](#1218)) ([c2f003c](c2f003c))
* revert pyproject.toml drop ([b5dbb5c](b5dbb5c))
* rust code used for testing must be allowed dead code ([#1148](#1148)) ([5997919](5997919))
* SetToSequence should be a method, not a function ([#1035](#1035)) ([1169bc8](1169bc8))
* smithy-dafny ([#1136](#1136)) ([6005777](6005777))

### Features

* Adds CI ([511ed35](511ed35))
* check in polymorph go generated code  ([#1137](#1137)) ([d0fefbf](d0fefbf))
* Check-in polymorph generated code ([bfc7cb9](bfc7cb9))
* ddb Go externs ([1e3737b](1e3737b))
* **ddb:** Go release v0.0.1 ([#1201](#1201)) ([5293bfd](5293bfd))
* **ddb:** Go release v0.0.3 ([#1210](#1210)) ([983f553](983f553))
* **Go:** Go module rename ([#1196](#1196)) ([b0876ac](b0876ac))
* kms externs for Go ([2d1f6d1](2d1f6d1))
* **kms:** Go release v0.0.1 ([#1199](#1199)) ([9c80544](9c80544))
* mpl externs ([#1105](#1105)) ([29bc52e](29bc52e))
* **mpl:** Go release v0.0.1 ([#1211](#1211)) ([4508ab8](4508ab8))
* Primitives CI ([ce6e942](ce6e942))
* Primitives for Go ([8066826](8066826))
* **primitives:** Go release v0.0.1 ([#1203](#1203)) ([6bf0bbe](6bf0bbe))
* StandardLibrary for Go ([587b57e](587b57e))
* StandardLibrary for Go ([94b4fd0](94b4fd0))
* StandardLibrary for Go ([6ce1ce3](6ce1ce3))
* **StdLib:** Go v0.0.1 release ([#1195](#1195)) ([95e54bf](95e54bf))
RitvikKapila pushed a commit that referenced this pull request Feb 3, 2025
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
a4b3136 
# [1.9.0](v1.8.0...v1.9.0) (2025-02-03)

### Bug Fixes

* CI ([d9e2a1e](d9e2a1e))
* DafnyLibraries.FileIO extern ([b150c48](b150c48))
* ECDH ValidatePublicKey err msg ([34a48fc](34a48fc))
* for test vectors, use SetToSequenceSorted ([#1034](#1034)) ([21ad206](21ad206))
* **GHW:** check-files apply to PR, not to diff b/w HEAD and branch ([#1075](#1075)) ([1f53a92](1f53a92))
* improve golang externs ([#1133](#1133)) ([b6ee16e](b6ee16e))
* **Java:** Improve Collection of Errors string ([#1056](#1056)) ([9e195a1](9e195a1))
* line breaks ([21536c7](21536c7))
* PR comments ([798214b](798214b))
* PR comments ([a21c0b3](a21c0b3))
* PR comments ([7dd95bc](7dd95bc))
* PR comments ([eed0d87](eed0d87))
* PR comments ([435515e](435515e))
* re-enable aes_gcm_192 ([#1143](#1143)) ([23650a9](23650a9))
* region ([5930ae4](5930ae4))
* region ([e3454b5](e3454b5))
* remove [@sensitive](https://github.com/sensitive) from smithy models ([#1123](#1123)) ([c939f3a](c939f3a))
* repo rename ([#1218](#1218)) ([c2f003c](c2f003c))
* revert pyproject.toml drop ([b5dbb5c](b5dbb5c))
* rust code used for testing must be allowed dead code ([#1148](#1148)) ([5997919](5997919))
* SetToSequence should be a method, not a function ([#1035](#1035)) ([1169bc8](1169bc8))
* smithy-dafny ([#1136](#1136)) ([6005777](6005777))

### Features

* Adds CI ([511ed35](511ed35))
* check in polymorph go generated code  ([#1137](#1137)) ([d0fefbf](d0fefbf))
* Check-in polymorph generated code ([bfc7cb9](bfc7cb9))
* ddb Go externs ([1e3737b](1e3737b))
* **ddb:** Go release v0.0.1 ([#1201](#1201)) ([5293bfd](5293bfd))
* **ddb:** Go release v0.0.3 ([#1210](#1210)) ([983f553](983f553))
* **Go:** Go module rename ([#1196](#1196)) ([b0876ac](b0876ac))
* kms externs for Go ([2d1f6d1](2d1f6d1))
* **kms:** Go release v0.0.1 ([#1199](#1199)) ([9c80544](9c80544))
* mpl externs ([#1105](#1105)) ([29bc52e](29bc52e))
* **mpl:** Go release v0.0.1 ([#1211](#1211)) ([4508ab8](4508ab8))
* Primitives CI ([ce6e942](ce6e942))
* Primitives for Go ([8066826](8066826))
* **primitives:** Go release v0.0.1 ([#1203](#1203)) ([6bf0bbe](6bf0bbe))
* StandardLibrary for Go ([587b57e](587b57e))
* StandardLibrary for Go ([94b4fd0](94b4fd0))
* StandardLibrary for Go ([6ce1ce3](6ce1ce3))
* **StdLib:** Go v0.0.1 release ([#1195](#1195)) ([95e54bf](95e54bf))
This was referenced Feb 3, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishav-karanjit rishav-karanjit rishav-karanjit approved these changes

@seebees seebees seebees left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhamChaturvedi7 @rishav-karanjit @seebees