Skip to content

Use of verify_interface #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reaperhulk opened this issue May 27, 2022 · 5 comments
Closed

Use of verify_interface #464

reaperhulk opened this issue May 27, 2022 · 5 comments

Comments

@reaperhulk
Copy link

Hi folks, I'm one of the developers of pyca/cryptography. We're planning to remove verify_interface (a function we've never publicly documented and is not part of our API contract) because it no longer has any use for us, but we noticed that you have two locations you currently call it in this codebase. In both cases you should be able to substitute a type check (either check the class itself or instantiate and do an isinstance) rather than using verify_instance. This will be backwards compatible to older cryptography and let us move forward with removal on our end.

@josecorella
Copy link
Contributor

Hello @reaperhulk!

Thank you for reaching out to us to let us know about the deprecation of verify_interface.
I see that on the issue you mentioned we are currently blocking you, do y’all have a scheduled date for a new release of pyca/cryptography which deprecates this function?

Best,

@reaperhulk
Copy link
Author

Our CI runs you as a downstream so we actually can't remove it without breaking our own CI 😄 We'd like to remove it for the next release though!

@josecorella
Copy link
Contributor

@reaperhulk,

Are y'all currently running releases on a cadence? If not, have y'all set date for the next release?

Best,

@alex
Copy link
Contributor

alex commented May 31, 2022

We do not have a date set. Historically our releases happen roughly every 3 months, would suggest July/August for our next release, but we don't have a fixed release schedule.

@josecorella
Copy link
Contributor

Hello @alex and @reaperhulk!

We have removed usage of verify_interface from the ESDK. You should now be able to deprecate the function on your end.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants