refactor: remove verify_interface #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding off on this review until #470 is addressed. |
josecorella
force-pushed
the
refactor_1.x_verify_interface
branch
from
da17313 to
ea306f8
Compare
josecorella
force-pushed
the
refactor_1.x_verify_interface
branch
from
35d8f61 to
8366b7a
Compare
texastony
previously approved these changes
Jun 14, 2022
test/unit/test_utils.py
Outdated
| def test_prep_stream_data_passthrough(): | ||
| test = aws_encryption_sdk.internal.utils.prep_stream_data(io.BytesIO(b"some data")) | ||
|
|
||
| assert_prepped_stream_identity(test, io.BytesIO) | ||
|
|
||
|
|
||
| def test_verify_interface(patch_ec): |
There was a problem hiding this comment.
Suggestion: Rename test_verify_ec_interface
Suggested change
| def test_verify_interface(patch_ec): | |
| def test_verify_ec_interface(patch_ec): |
texastony
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#464
Description of changes:
verify_interfaceBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: