Skip to content

refactor: remove verify_interface #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

josecorella
Copy link
Contributor

@josecorella josecorella commented Jun 9, 2022

Issue #, if available:
#464

Description of changes:

  • Remove verify_interface
  • Fix linting

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@josecorella josecorella changed the title Refactor 2.x verify interface refactor: remove verify_interface Jun 9, 2022
@josecorella josecorella marked this pull request as ready for review June 10, 2022 16:11
@josecorella josecorella requested a review from a team as a code owner June 10, 2022 16:11
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 blocking comments.
I have not reviewed the files under test.
If we re-implement verify_interface in
aws_encryption_sdk/internal/utils/__init__.py,
we may need to refactor the tests... not sure yet.

@texastony texastony mentioned this pull request Jun 10, 2022
1 task
@josecorella josecorella requested a review from texastony June 14, 2022 20:51
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

texastony
texastony previously approved these changes Jun 14, 2022
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with Suggestion

def test_prep_stream_data_passthrough():
test = aws_encryption_sdk.internal.utils.prep_stream_data(io.BytesIO(b"some data"))

assert_prepped_stream_identity(test, io.BytesIO)


def test_verify_interface(patch_ec):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Rename test_verify_ec_interface

Suggested change
def test_verify_interface(patch_ec):
def test_verify_ec_interface(patch_ec):

@josecorella josecorella merged commit ff13d9c into aws:mainline-2.x Jun 15, 2022
@josecorella josecorella deleted the refactor_2.x_verify_interface branch June 15, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants