Add the --unsafe-perm flag to to npm install #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPM will not execute any script hooks if it is running as root, which is common in docker environments. Adding --unsafe-perm enables this.
jfuss
reviewed
Mar 23, 2020
Co-Authored-By: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
Contributor
|
closing since #163 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
NPM will not execute any script hooks if it is running as root, which is common in docker environments (i.e
sam build --use-container). Thepostinstallscript hook is commonly used by many libraries (especially ones involving native bindings), and it is highly confusing as to why hooks are not run when executingsam build --use-containerversussam buildlocally.Adding --unsafe-perm enables this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.