Make sure NPM hooks are called #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPM will not execute hooks when install is called as root. Since this is very common in scenarios where containers are involved, it makes sense to enable this flag
Contributor
Author
|
Any news? |
sriram-mv
approved these changes
May 7, 2020
Contributor
sriram-mv
left a comment
sriram-mv
left a comment
There was a problem hiding this comment.
Read up on unsafe perm and this change looks good to me.
Contributor
Author
|
Glad to hear that :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from here since the original creator did not respond and only a small change was needed: #161