-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document no-op functions and flags in AWS-LC #1473
Conversation
e285db5
to
a436cec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
==========================================
+ Coverage 77.01% 77.19% +0.17%
==========================================
Files 426 426
Lines 71738 71449 -289
==========================================
- Hits 55252 55157 -95
+ Misses 16486 16292 -194 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use our OPENSSL_DEPRECATED macro for many of these function declarations?
Good point, this was brought up as something to do, but I hadn't realized we could do it along with this PR. |
fceb872
to
020fb7a
Compare
020fb7a
to
b78680d
Compare
9ef968a
to
ad8d97b
Compare
ad8d97b
to
5fae381
Compare
This finalizes the changes for the previous two documentation PRS: #1463 and #1473. Now that these two PRs are in, we have a commit to link the header documentation from the table. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Description of changes:
Update porting guide for AWS-LC. This is the second phase which includes updated function documentation.
Call-outs:
Originally, this was to include links to the corresponding functions/sections in the new tables as well, but we can't actually provide correct links until we have the correct commit hash in main.
A third phase will link the tables to the corresponding section.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.