Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Remove the need of cdk arn class in PasswordSecretArnValidator #5294

Merged
merged 1 commit into from
May 10, 2023

Conversation

eantonin
Copy link
Contributor

Description of changes

  • Remove the need of cdk arn class in PasswordSecretArnValidator

Tests

  • The JUnit excercising that part were already present and they are still passing
  • Launched 8 clusters with the custom resource, before the fix this would have almost surely showed at least an error, while it is not showing any error now, all validations succeeded

References

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@eantonin eantonin added the skip-changelog-update Disables the check that enforces changelog updates in PRs label May 10, 2023
@eantonin eantonin requested review from a team as code owners May 10, 2023 14:17
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #5294 (47a7eb8) into release-3.6 (c8fac87) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-3.6    #5294   +/-   ##
============================================
  Coverage        89.74%   89.74%           
============================================
  Files              175      175           
  Lines            15256    15258    +2     
============================================
+ Hits             13692    13694    +2     
  Misses            1564     1564           
Flag Coverage Δ
unittests 89.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@enrico-usai enrico-usai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great job finding the root cause of the issue, nice explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants