Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set feature flag for unique launch template names to fix integ tests #1165

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

marofke
Copy link
Contributor

@marofke marofke commented Dec 20, 2023

Problem

Integration tests were failing to deploy some stacks due to Launch template name collisions. This is due to the IMSDv2 aspect requiring a feature flag for a launch template name to be unique.

Solution

Set the feature flag in the cdk.json files for the integration tests

Testing

Synthesized a simple CDK app with and without the feature flag set, confirming a LaunchTemplate in the template receive a unique name with the feature flag.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ests

Signed-off-by: Caden Marofke <marofke@amazon.com>
@jusiskin jusiskin changed the title fix: set feature flag for unique launch template names to fix integ tests ci: set feature flag for unique launch template names to fix integ tests Dec 20, 2023
@jusiskin jusiskin changed the title ci: set feature flag for unique launch template names to fix integ tests test: set feature flag for unique launch template names to fix integ tests Dec 20, 2023
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Only thing is the commit's category was fix: ... which should instead be test: .... I've renamed the PR so that should become the squashed commit (if the person merging reloads the page since I've renamed it).

@jusiskin jusiskin merged commit da99c9a into mainline Dec 20, 2023
3 checks passed
@jusiskin jusiskin deleted the marofke/integ-launch-template-feature-flag branch December 20, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants