test: add unique discriminator to testing-tier props #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caden Marofke <marofke@amazon.com>
ddneilson
approved these changes
Dec 20, 2023
edwards-aws
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Integration tests were failing to deploy the Bastion instance in the testing tier, since the name is not unique. Changes in #1165 enabled a feature flag that append a unique hash to the construct name, but base the hash on the CFN node a step down from the full stack name, resulting in the same hash for every test stack.
Solution
Append a 'discriminator' tag to the Bastion name, which helps keep the name unique between instances of the testing-tier. I also appended the "integStackTag" so multiple deployments won't cause resource conflicts.
Testing
Built locally, confirming no linting errors.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license