test: set feature flag for unique launch template names to fix integ tests #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests Signed-off-by: Caden Marofke <marofke@amazon.com>
jusiskin
changed the title
jusiskin
changed the title
ddneilson
approved these changes
Dec 20, 2023
jusiskin
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Integration tests were failing to deploy some stacks due to Launch template name collisions. This is due to the IMSDv2 aspect requiring a feature flag for a launch template name to be unique.
Solution
Set the feature flag in the
cdk.jsonfiles for the integration testsTesting
Synthesized a simple CDK app with and without the feature flag set, confirming a LaunchTemplate in the template receive a unique name with the feature flag.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license