Accept non-integer statusCode JSON values#1013
Merged
jfuss merged 2 commits intoaws:developfrom Feb 19, 2019
Merged
Conversation
sanathkr
approved these changes
Feb 15, 2019
Contributor
sanathkr
left a comment
sanathkr
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix
jfuss
suggested changes
Feb 15, 2019
Contributor
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Could you also add integration tests for this? This will help us make sure changes don't regress behavior in the future.
Contributor
Author
|
I've added an integration test in what I think is the right place. I get S3 client errors trying to run those tests locally so we'll see what Travis says. |
Contributor
|
@slank Thanks for adding the tests. Some of our integ-tests require creds, so it's could be either you don't have the correct permissions or no credentials. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The Lambda proxy integration for API Gateway does not specify that statusCode must be an integer, but SAM CLI requires it. This change fixes SAM CLI to accept non-integer status codes that contain integer values.
See slank/awsgi#23 for additional background.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.