This repository was archived by the owner on Mar 13, 2024. It is now read-only.
Closed
Conversation
Owner
|
@mathom Thanks for this very well-written PR! Merging this would break backward compatibility, and after a little digging I think the solution would be to fix SAM CLI to handle a string I'm working on that PR now and once it's released I'll decline this one. Be back in a bit with a link to that. |
6 tasks
Owner
|
SAM CLI PR: aws/aws-sam-cli#1013 |
Author
|
Great, thanks for the quick response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current response returns a stringified
statusCode. This jams up AWS SAM when it's ran locally:Here's the SAM setup to reproduce this:
requirements.txt:api.py:template.yaml:Test locally: