Skip to content

Conversation

@sanathkr
Copy link
Contributor

Issue #, if available:

Description of changes:

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv self-requested a review February 28, 2019 22:50
sriram-mv
sriram-mv previously approved these changes Feb 28, 2019
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooo 🥇

- while testing for custom profiles, make sure environment variables are
  not already set, as it looks like preset environment variables get
  precendence over setting via profiles.
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Says thanks to all the travis gods in support of this PR.

@sanathkr sanathkr merged commit 7ddb5e4 into master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants