-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Depend on development version of lambda-builders for dev builds #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sriram-mv
merged 4 commits into
aws:dotnet_build_support
from
sanathkr:dev-dependencies
Apr 10, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,3 @@ | ||
| coverage==4.3.4 | ||
| flake8==3.3.0 | ||
| tox==2.2.1 | ||
| pytest-cov==2.4.0 | ||
| # astroid > 2.0.4 is not compatible with pylint1.7 | ||
| astroid>=1.5.8,<2.1.0 | ||
| pylint==1.7.2 | ||
|
|
||
| # Test requirements | ||
| pytest==3.0.7 | ||
| py==1.4.33 | ||
| mock==2.0.0 | ||
| parameterized==0.6.1 | ||
| pathlib2==2.3.2; python_version<"3.4" | ||
| futures==3.2.0; python_version<"3.2.3" | ||
| # Py3.2 backport | ||
| backports.tempfile==1.0 | ||
| # Following are "dev" version of libraries that SAM CLI consumes for development purposes. | ||
| # For production releases, see prod.txt where these libraries are pinned to a particular version | ||
| -e git://github.com/awslabs/aws-lambda-builders.git@develop#egg=aws_lambda_builders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # SAM CLI depends on these libraries that the team authors/controls. Pinning them to particular version here | ||
| # for production usage. | ||
|
|
||
| aws_lambda_builders==0.2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| coverage==4.3.4 | ||
| flake8==3.3.0 | ||
| tox==2.2.1 | ||
| pytest-cov==2.4.0 | ||
| # astroid > 2.0.4 is not compatible with pylint1.7 | ||
| astroid>=1.5.8,<2.1.0 | ||
| pylint==1.7.2 | ||
|
|
||
| # Test requirements | ||
| pytest==3.0.7 | ||
| py==1.4.33 | ||
| mock==2.0.0 | ||
| parameterized==0.6.1 | ||
| pathlib2==2.3.2; python_version<"3.4" | ||
| futures==3.2.0; python_version<"3.2.3" | ||
| # Py3.2 backport | ||
| backports.tempfile==1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have silently changed the contract of make init now, to always build the latest from lambda-builders in develop. this can have issues when there is a breaking change in lambda builders develop, but the corresponding component to fix sam cli has not yet been merged.
we need to keep this in mind and fix it.