Depend on development version of lambda-builders for dev builds#1111
Merged
sriram-mv merged 4 commits intoaws:dotnet_build_supportfrom Apr 10, 2019
Merged
Depend on development version of lambda-builders for dev builds#1111sriram-mv merged 4 commits intoaws:dotnet_build_supportfrom
sriram-mv merged 4 commits intoaws:dotnet_build_supportfrom
Conversation
sriram-mv
approved these changes
Apr 9, 2019
| @@ -1,5 +1,7 @@ | |||
| init: | |||
| SAM_CLI_DEV=1 pip install -e '.[dev]' | |||
| SAM_CLI_DEV=1 pip install -e . | |||
Contributor
There was a problem hiding this comment.
we have silently changed the contract of make init now, to always build the latest from lambda-builders in develop. this can have issues when there is a breaking change in lambda builders develop, but the corresponding component to fix sam cli has not yet been merged.
we need to keep this in mind and fix it.
6 tasks
sriram-mv
pushed a commit
that referenced
this pull request
Apr 16, 2019
* chore(version): set 0.14.3.dev1 version (#1112) (#1113) * Depend on development version of lambda-builders for dev builds (#1111) * Depend on development version of lambda-builders for dev builds * Adding prod.txt to manifest * Splitting dev and tool dependencies * fix(build): Resolve path after .aws-sam is created (#1110) * fix(build): Resolve path after .aws-sam is created * fix: build (make pr) * Design and implementation for producing debug build artifacts (#1095) * design: Initial Design for producing debug artifacts * initial implementation * Adding unit tests * Integration test with debug build mode * Adjust Design doc and add keyword arg to a call * fix(dotnet): init template fixes (#1117) * chore(version): set 0.15.0 (#1125) * Revert "Depend on development version of lambda-builders for dev builds (#1111)" (#1128) This reverts commit 7e9de79. * Bumping to Lambda Builders 0.3.0 (#1129) Bumping to Lambda Builders 0.3.0 * fix(func-tests): add dependency manager param (#1130)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
During development, we can't easily use development versions of other dependencies such as AWS Lambda Builders.
Description of changes:
In this change, I have separated out dev requirements from prod requirements. For Production, the dependencies are version pinned and pulled from PyPi. For dev requirements, the dependencies are pulled directly from Github source.
I had to remote the
extras_requiresin setup.py because it did not support installing from Github. Instead I modified the Makefile to pip install these dependencies separately. This is acceptable for development builds.For production, I concatenate
base.txtwithprod.txtand use it as the final list of requirements.Testing:
Following commands worked as expected
SAM_CLI_DEV=1 pip install -e .pip install -e .make initChecklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.