Skip to content

chore(version): set 0.14.3.dev1 version#1112

Merged
sriram-mv merged 1 commit intoaws:developfrom
sriram-mv:dev_branch
Apr 10, 2019
Merged

chore(version): set 0.14.3.dev1 version#1112
sriram-mv merged 1 commit intoaws:developfrom
sriram-mv:dev_branch

Conversation

@sriram-mv
Copy link
Contributor

Issue #, if available:

Description of changes:

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we follow https://www.python.org/dev/peps/pep-0440/ for pre-release version schema? Setting the pattern now will allow us to do dev releases to PyPi in the future.

@sriram-mv
Copy link
Contributor Author

sriram-mv commented Apr 10, 2019

I looked at number 9 in https://semver.org/, but looks like https://www.python.org/dev/peps/pep-0440/#id50 states the below.

“Semantic versions containing a hyphen (pre-releases - clause 10) or a plus sign (builds - clause 11) are not compatible with this PEP and are not permitted in the public version field."

So, lets change it according to the pep.

@sriram-mv
Copy link
Contributor Author

changed according to pep.

One possible mechanism to translate such semantic versioning based source labels to compatible public versions is to use the .devN suffix to specify the appropriate version order.

https://www.python.org/dev/peps/pep-0440/#id50

@sriram-mv sriram-mv changed the base branch from develop to dotnet_build_support April 10, 2019 16:40
@sriram-mv sriram-mv changed the title chore(version): set 0.14.3 dev version chore(version): set 0.14.3.dev1 version Apr 10, 2019
@sriram-mv sriram-mv changed the base branch from dotnet_build_support to develop April 10, 2019 16:47
@sriram-mv sriram-mv merged commit 9fcd828 into aws:develop Apr 10, 2019
sriram-mv pushed a commit that referenced this pull request Apr 16, 2019
* chore(version): set 0.14.3.dev1 version (#1112) (#1113)

* Depend on development version of lambda-builders for dev builds (#1111)

* Depend on development version of lambda-builders for dev builds

* Adding prod.txt to manifest

* Splitting dev and tool dependencies

* fix(build): Resolve path after .aws-sam is created (#1110)

* fix(build): Resolve path after .aws-sam is created

* fix: build (make pr)

* Design and implementation for producing debug build artifacts (#1095)

* design: Initial Design for producing debug artifacts

* initial implementation

* Adding unit tests

* Integration test with debug build mode

* Adjust Design doc and add keyword arg to a call

* fix(dotnet): init template fixes (#1117)

* chore(version): set 0.15.0 (#1125)

* Revert "Depend on development version of lambda-builders for dev builds (#1111)" (#1128)

This reverts commit 7e9de79.

* Bumping to Lambda Builders 0.3.0 (#1129)

Bumping to Lambda Builders 0.3.0

* fix(func-tests): add dependency manager param (#1130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants