fix(build): Resolve path after .aws-sam is created#1110
Merged
sriram-mv merged 2 commits intoaws:dotnet_build_supportfrom Apr 10, 2019
Merged
fix(build): Resolve path after .aws-sam is created#1110sriram-mv merged 2 commits intoaws:dotnet_build_supportfrom
sriram-mv merged 2 commits intoaws:dotnet_build_supportfrom
Conversation
sanathkr
approved these changes
Apr 9, 2019
sriram-mv
reviewed
Apr 9, 2019
|
|
||
| os_patch.listdir.assert_called_once() | ||
| path_mock.exists.assert_called_once() | ||
| path_mock.mkdir.assert_called_once_with(mode=0o755, parents=True, exist_ok=True) |
Contributor
There was a problem hiding this comment.
nit: can we use BuildContext._BUILD_DIR_PERMISSIONS here instead of 755 explicitly.
edit: thought about it, it would be like accessing protected member, so never mind.
sriram-mv
pushed a commit
that referenced
this pull request
Apr 16, 2019
* chore(version): set 0.14.3.dev1 version (#1112) (#1113) * Depend on development version of lambda-builders for dev builds (#1111) * Depend on development version of lambda-builders for dev builds * Adding prod.txt to manifest * Splitting dev and tool dependencies * fix(build): Resolve path after .aws-sam is created (#1110) * fix(build): Resolve path after .aws-sam is created * fix: build (make pr) * Design and implementation for producing debug build artifacts (#1095) * design: Initial Design for producing debug artifacts * initial implementation * Adding unit tests * Integration test with debug build mode * Adjust Design doc and add keyword arg to a call * fix(dotnet): init template fixes (#1117) * chore(version): set 0.15.0 (#1125) * Revert "Depend on development version of lambda-builders for dev builds (#1111)" (#1128) This reverts commit 7e9de79. * Bumping to Lambda Builders 0.3.0 (#1129) Bumping to Lambda Builders 0.3.0 * fix(func-tests): add dependency manager param (#1130)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1101
Description of changes:
See #1101 (comment) for more details.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.