doc: Adding testing guidelines#1201
Merged
jfuss merged 1 commit intoaws:candidate/release/20from Jul 26, 2019
Merged
Conversation
sriram-mv
suggested changes
Jun 3, 2019
| > Aim to test with complete isolation | ||
|
|
||
| - When your code uses external dependencies, write **functional tests** | ||
| to verify some flows by including as many external dependencies as |
Contributor
There was a problem hiding this comment.
I dont think it should state as many external dependencies, but just explicitly the dependencies that need to be tested.
Contributor
Author
There was a problem hiding this comment.
We don't know what these dependencies are here. I provided some examples in later sentence instead
sriram-mv
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.