fix: change the multiple functions warning message colour to yellow #3546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchengru
suggested changes
Dec 22, 2021
| message = ( | ||
| f"Multiple functions found with keyword {name}! Function {found_fs[0].full_path} will be " | ||
| f"invoked! If it's not the function you are going to invoke, please choose one of them from" | ||
| f" below:" |
Contributor
There was a problem hiding this comment.
name,found_fs[0].full_path, Do we want to add these to the message?
Contributor
Author
There was a problem hiding this comment.
they are already there
f"Multiple functions found with keyword <<<{name}!>>>> Function <<<<{found_fs[0].full_path}>>>> will be "
wchengru
approved these changes
Dec 22, 2021
hawflau
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
change the multiple functions warning message colour to yellow
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.