Skip to content

fix: change the multiple functions warning message colour to yellow #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moelasmar merged 4 commits into from
Dec 22, 2021
Merged

fix: change the multiple functions warning message colour to yellow #3546

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15378e9
change the multiple functions warning message color to yellow
moelasmar Dec 22, 2021
cdbf322
Merge branch 'develop' into develop-use-yellow-color-for-warning-message
moelasmar Dec 22, 2021
14d4dba
Merge branch 'develop' into develop-use-yellow-color-for-warning-message
moelasmar Dec 22, 2021
dabfcff
Merge branch 'develop' into develop-use-yellow-color-for-warning-message
moelasmar Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions samcli/lib/providers/sam_function_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,16 +97,15 @@ def get(self, name: str) -> Optional[Function]:
if len(found_fs) > 1:
found_fs.sort(key=lambda f0: f0.full_path.lower())

LOG.warning(
"Multiple functions found with keyword %s! Function %s will be invoked! "
"If it's not the function you are going to invoke,"
"please choose one of them from below:",
name,
found_fs[0].full_path,
message = (
f"Multiple functions found with keyword {name}! Function {found_fs[0].full_path} will be "
f"invoked! If it's not the function you are going to invoke, please choose one of them from"
f" below:"
Copy link
Contributor

@wchengru wchengru Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name,found_fs[0].full_path, Do we want to add these to the message?

Copy link
Contributor Author

@moelasmar moelasmar Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are already there
f"Multiple functions found with keyword <<<{name}!>>>> Function <<<<{found_fs[0].full_path}>>>> will be "

)
LOG.warning(Colored().yellow(message))

for found_f in found_fs:
LOG.warning(found_f.full_path)
LOG.warning(Colored().yellow(found_f.full_path))

resolved_function = found_fs[0]

Expand Down