Skip to content

Conversation

@moelasmar
Copy link
Contributor

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor Author

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR depends on PR. Build Failures should be resolved once we merged the previous PR, and updated this one.

…p-cdk-warm-containers

# Conflicts:
#	samcli/local/lambdafn/runtime.py
@moelasmar moelasmar merged commit 00fb6e8 into aws:develop Jan 4, 2022
@moelasmar moelasmar deleted the develop-cdk-warm-containers branch January 4, 2022 00:25
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
* support warm-containers to CDK templates

* fix integration test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants