Fix issue in cloning app templates repo in windows#3950
Merged
hawflau merged 8 commits intoaws:developfrom Jun 9, 2022
Merged
Conversation
mndeveci
reviewed
Jun 8, 2022
mndeveci
approved these changes
Jun 9, 2022
moelasmar
approved these changes
Jun 9, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#3946
Why is this change necessary?
App templates repo contains some very long paths in which Windows doesn't support them as it has a limitation of 260 chars.
How does it address the issue?
This change modifies the
git clonecommand by appending--config core.longpaths=trueif the system is Windows. The config is only applied for the cloned repo (i.e. the app templates repo) and won't affect user's system settings.What side effects does this change have?
No
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.