Reduced the length of the cloned app template folder name#4542
Merged
hawflau merged 4 commits intoaws:developfrom Jan 6, 2023
Merged
Reduced the length of the cloned app template folder name#4542hawflau merged 4 commits intoaws:developfrom
hawflau merged 4 commits intoaws:developfrom
Conversation
qingchm
approved these changes
Jan 6, 2023
Contributor
Author
From what I can gather, we can just leave that PR fix in place since its not changing anything about the way we digest the templates. Even though we could remove it since we are now reducing the paths of our templates, imo it doesn't hurt to leave it in so that we know that this won't happen with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
This is one of the changes being made to help reduce the overall length of cloned app templates to avoid reaching the maximum path length in Windows.
How does it address the issue?
Changes the folder name from
aws-sam-cli-app-templatestotmplfor Windows machines.What side effects does this change have?
Existing Windows installations with an
aws-sam-cli-app-templatesfolder in their%appdata%/AWS SAMdirectory will have that folder remain there until it is manually deleted.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.