fix: use resource type instead of resource id for deciding zip method #4485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
approved these changes
Dec 15, 2022
| @patch("samcli.lib.package.utils.zip_and_upload") | ||
| def test_upload_local_artifacts_local_folder_lambda_resources(self, zip_and_upload_mock): | ||
| for resource_id in LAMBDA_LOCAL_RESOURCES: | ||
| for resource_type in LAMBDA_LOCAL_RESOURCES: |
Contributor
There was a problem hiding this comment.
Looks like this was full-filling test before then.. Thanks for the fix!
qingchm
approved these changes
Dec 15, 2022
qingchm
reviewed
Dec 15, 2022
| read_until_string( | ||
| self.watch_process, | ||
| "\x1b[32mFinished syncing Function Layer Reference Sync HelloWorldFunction.\x1b[0m\n", | ||
| "\x1b[32mFinished syncing Layer HelloWorldFunction", |
Contributor
There was a problem hiding this comment.
Let's change this to function instead of layer, and update L136 to be the same
Contributor
There was a problem hiding this comment.
Sorry nevermind this is actually supposed to be layer, but I'm raising a CR to update the validation on L136 to be the same as this one
8 tasks
Merged
mndeveci
added a commit
that referenced
this pull request
Jan 21, 2023
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
With this PR #4462, we've changed some permissions of the files in ZIP package if the file is used for serverless function resources. But that is checking if logical id of the resource is type.
How does it address the issue?
With this change, we are checking the resource type instead of resource logical id.
What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.