-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: file/directory permissions within the zip while packaging artifacts #4655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: file/directory permissions within the zip while packaging artifacts #4655
Conversation
jfuss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably out of scope for this PR but I think it would be a good idea to add integration tests for a compiled and interpreted language that package, deploy, and then invoke the function. I will leave that up to you but at the very least, I think we should add that before this is released.
qingchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mndeveci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! I've requested some small changes to make it more readable. I also agree for adding an integration test to verify this behavior which would also help us to not break this in the future.
67827a3 to
c8e78d5
Compare
* Additive permissions to add execute on directories and read on files.
599f0ab to
2e56ea6
Compare
2e56ea6 to
c961fb7
Compare
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.