Skip to content

Conversation

@lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Jul 14, 2023

Why is this change necessary?

Windows paths contain an escape backslash (\\). This needs to be turned into a POSIX path before being parsed/saved into the template file.

How does it address the issue?

Makes sure that the string path from the helper method is a POSIX path (/ instead of \\) before parsing.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/internal area/build sam build command and removed pr/internal labels Jul 14, 2023
@lucashuy lucashuy marked this pull request as ready for review July 14, 2023 19:08
@lucashuy lucashuy requested a review from a team as a code owner July 14, 2023 19:08
@lucashuy lucashuy requested review from hawflau and sriram-mv July 14, 2023 19:08
@lucashuy lucashuy added this pull request to the merge queue Jul 14, 2023
Merged via the queue into aws:develop with commit b536b83 Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build sam build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants