Skip to content

Conversation

@lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Jul 17, 2023

Which issue(s) does this change fix?

Related:
yaml/pyyaml#724
#5494
aws/homebrew-tap#491

Why is this change necessary?

cython is breaking the PyYAML building process when building from source.

How does it address the issue?

Enforces a lower cython version to specifically build PyYAML before uninstalling cython and processing with the rest of the step.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review July 17, 2023 21:42
@lucashuy lucashuy requested a review from a team as a code owner July 17, 2023 21:42
@lucashuy lucashuy requested review from jfuss and moelasmar and removed request for a team July 17, 2023 21:42
@lucashuy lucashuy changed the title chore: Pin cython to a version that is less than 3.0.0 fix: Pin cython to a version that is less than 3.0.0 Jul 17, 2023
@sriram-mv sriram-mv self-requested a review July 17, 2023 23:57
@lucashuy lucashuy merged commit 5ba20b5 into aws:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants