Skip to content

fix: Pin cython to a version that is less than 3.0.0 #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucashuy merged 5 commits into from
Jul 18, 2023
Merged

fix: Pin cython to a version that is less than 3.0.0 #5544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2753b0d
Pin cython to a version less than 3.0.0
lucashuy Jul 17, 2023
203b45b
Moved install location to be inside of virtual env
lucashuy Jul 17, 2023
737605f
Install cython and pyyaml together
lucashuy Jul 17, 2023
34c9223
Moved uninstall logic to after custom build
lucashuy Jul 17, 2023
b965160
Add auto confirm to uninstall
lucashuy Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
SAM_CLI_TELEMETRY ?= 0

init:
pip install wheel
pip install "cython<3.0.0" pyyaml==5.4.1 --no-build-isolation
pip uninstall wheel cython --yes
SAM_CLI_DEV=1 pip install -e '.[dev]'

test:
Expand Down
10 changes: 10 additions & 0 deletions installer/pyinstaller/build-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,16 @@ cd ..
echo "Installing Python Libraries"
python3 -m venv venv
./venv/bin/pip install --upgrade pip

# https://github.com/yaml/pyyaml/issues/724
echo "Force cython package version to be lower than 3.x.x"
./venv/bin/pip install wheel
./venv/bin/pip install --no-build-isolation "cython<3.0.0" pyyaml==5.4.1

echo "Uninstall local cython package"
./venv/bin/pip uninstall wheel cython --yes
# end cython work around

./venv/bin/pip install -r src/requirements/reproducible-linux.txt

echo "Copying All Python Libraries"
Expand Down
10 changes: 10 additions & 0 deletions installer/pyinstaller/build-mac.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,16 @@ cd ..
echo "Installing Python Libraries"
/usr/local/bin/python3.8 -m venv venv
./venv/bin/pip install --upgrade pip

# https://github.com/yaml/pyyaml/issues/724
echo "Force cython package version to be lower than 3.x.x"
./venv/bin/pip install wheel
./venv/bin/pip install --no-build-isolation "cython<3.0.0" pyyaml==5.4.1

echo "Uninstall local cython package"
./venv/bin/pip uninstall wheel cython --yes
# end cython work around

./venv/bin/pip install -r src/requirements/reproducible-mac.txt

echo "Copying All Python Libraries"
Expand Down