Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading ca_bundle from shared config files #1589

Closed
1 task done
gdavison opened this issue Feb 16, 2022 · 2 comments · Fixed by #1593
Closed
1 task done

Support reading ca_bundle from shared config files #1589

gdavison opened this issue Feb 16, 2022 · 2 comments · Fixed by #1593
Labels
feature-request A feature should be added or improved.

Comments

@gdavison
Copy link
Contributor

Describe the feature

The shared config file parameter ca_bundle is supported by the AWS CLI. However, this cannot be accessed using the AWS SDK for Go.

Is your Feature Request related to a problem?

There is no way to programatically access the ca_bundle setting from the shared config file. This can lead to confusion when applications don't pick up some settings from shared config, but do pick up others.

Proposed Solution

The CustomCABundle parameter should be read by the SharedConfig resolver

Describe alternatives you've considered

No response

Acknowledge

  • I may be able to implement this feature request

AWS Go SDK version used

github.com/aws/aws-sdk-go-v2 v1.13.0

Go version used

go version go1.17.2 darwin/amd64
@gdavison gdavison added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2022
This was referenced Feb 16, 2022
Closed
Closed
Merged
@jasdel jasdel mentioned this issue Feb 22, 2022
Closed
1 task
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this issue Feb 22, 2022
@jasdel
config: Add support for SharedConfig file ca_bundle parameter
4468900 
Adds support for the `ca_bundle` parameter in shared config and
credentials files. The usage of the file is the same as environment
variable, `AWS_CA_BUNDLE`, but sourced from shared config.

Fixes aws#1589

Usage:
  [profile myProfile]
  ca_bundle = path/to/ca/bundle.pem
@jasdel jasdel mentioned this issue Feb 22, 2022
Merged
@jasdel jasdel removed the needs-triage This issue or PR still needs to be triaged. label Feb 22, 2022
@jasdel
Copy link
Contributor

jasdel commented Feb 22, 2022

Thanks for taking the time to create this issue @gdavison. I've putout PR #1593 that adds support for the ca_bundle shared config parameter.

jasdel added a commit that referenced this issue Feb 23, 2022
@jasdel
config: Add support for SharedConfig file ca_bundle parameter (#1593)
b7ee4d6 
Adds support for the `ca_bundle` parameter in shared config and
credentials files. The usage of the file is the same as environment
variable, `AWS_CA_BUNDLE`, but sourced from shared config.

Fixes #1589

Usage:
  [profile myProfile]
  ca_bundle = path/to/ca/bundle.pem
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: Add support for SharedConfig file ca_bundle parameter jasdel/aws-sdk-go-v2
2 participants
@jasdel @gdavison