Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/s3: Update hostCompatibleBucketName doc to reflect #848 changes #1683

Merged
merged 2 commits into from
May 5, 2022
Merged

service/s3: Update hostCompatibleBucketName doc to reflect #848 changes #1683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a20bc9a
Update hostCompatibleBucketName doc to reflect #848 changes
lggomez Apr 26, 2022
be471e4
Tweak hostCompatibleBucketName updated docs
jasdel Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions service/s3/internal/customizations/update_endpoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ type UpdateEndpointParameterAccessor struct {

// UpdateEndpointOptions provides the options for the UpdateEndpoint middleware setup.
type UpdateEndpointOptions struct {

// Accessor are parameter accessors used by the middleware
Accessor UpdateEndpointParameterAccessor

Expand Down Expand Up @@ -256,8 +255,11 @@ func removeBucketFromPath(u *url.URL, bucket string) {
}

// hostCompatibleBucketName returns true if the request should
// put the bucket in the host. This is false if S3ForcePathStyle is
// explicitly set or if the bucket is not DNS compatible.
// put the bucket in the host. This is false if the bucket is not
// DNS compatible or the EndpointResolver resolves an aws.Endpoint with
// HostnameImmutable member set to true.
//
// https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/aws#Endpoint.HostnameImmutable
func hostCompatibleBucketName(u *url.URL, bucket string) bool {
// Bucket might be DNS compatible but dots in the hostname will fail
// certificate validation, so do not use host-style.
Expand Down