service/s3: Update hostCompatibleBucketName doc to reflect #848 changes #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lggomez
force-pushed
the
service/s3/endpoint_doc_update
branch
from
2027653 to
a20bc9a
Compare
lggomez
changed the title
Updates the doc string for hostCompatibleBucketName adding link to the resolved Endpoint member driving the behavior.
jasdel
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the comment for the method as S3ForcePathStyle was deprecated and at a first glance it is not obvious why the default behavior changes when migrating from SDK v1 to V2 and how to enforce the endpoint to not append the bucket name. This includes #848
PS: I saw the PR template about opening an issue first but it wasn't clear which files are autogenerated and which ones are not (if everything under feature/* falls into this category). If the former is needed please tell me