Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/request: Add LimitExceededException throttled exception for Kinesis #2512

Closed
wants to merge 1 commit into from

Conversation

pdalinis
Copy link

Kinesis returns LimitExceededException when the rate limit is hit. This PR adds this exception to the list of throttled exceptions.

Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR @pdalinis. I think the idea of this change is good, but I don't think we can accept this change as in. Specifically because the LimitExceededException is a common exception returned by multiple services with different meanings.

This exception was originally in the SDK but removed in #1276 because it was found to conflict with DynamoDB's usage of this same exception code. Later another issue, #1376 was raised with the SDK about not retrying the LimitExceededException in Kinesis as well.

I think if the SDK were to retry this exception we need to take a deeper look at how the SDK chooses to retry exceptions. Potentially updating the SDK to apply some retry behavior to specific API operations or services. e.g LimitExceededException would be retried for Kinesis but not DynamoDB. This SDK does not currently have this behavior.

Lets track this discussion and design in, #1376.

@jasdel jasdel changed the title Add LimitExceededException, to set of throttled exceptions, for Kinesis aws/request: Add LimitExceededException throttled exception for Kinesis Mar 21, 2019
@jasdel
Copy link
Contributor

jasdel commented May 17, 2019

Thanks for taking to time to create this PR, but lets use the #1376 item to track how the SDK could implement service specific retry behavior. Closing this PR in favor of that issue.

@jasdel jasdel closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants