Skip to content

Conversation

@cenedhryn
Copy link
Contributor

@cenedhryn cenedhryn commented Sep 13, 2023

Motivation and Context

When the Sigv4a signer is used, path normalization is true by default. This causes issues for S3 MRAP usage, where some paths don't work - S3 does not perform path normalization

Modifications

This bugfix checks the signer attribute to see if it has a value, and chooses that value if it exists. Otherwise, it will fall back to true, which is the general Sigv4 setting. S3 and S3 Control always sets the path normalization to false.

Testing

No unit testing is possible because the normalization is performed in CRT, not in the SDK

Edit: added the path tests to existing integ tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

…hich causes signature mismatch errors with S3 service
@cenedhryn cenedhryn requested a review from a team as a code owner September 13, 2023 16:22
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@cenedhryn cenedhryn merged commit 3634ff4 into master Sep 18, 2023
@cenedhryn cenedhryn deleted the salande/sigv4a-path-normalization-fix branch September 23, 2023 04:42
aws-sdk-java-automation added a commit that referenced this pull request Oct 27, 2025
…0b109ff98

Pull request: release <- staging/56895f9f-741e-40b2-855f-a670b109ff98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants