Skip to content

Change config for Sigv4a signing to not perform path normalization #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Change config for Sigv4a signing to not perform path normalization #4430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd7517e
Change config for Sigv4a signing to not perform path normalization, w…
cenedhryn Sep 13, 2023
2a74a9f
Adds different paths to MRAP integration test
cenedhryn Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-AWSSDKforJavav2-750825c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "AWS SDK for Java v2",
"contributor": "",
"description": "Do not instruct the CRT Sigv4a signer to do path normalization to avoid signature mismatch errors"
}
14 changes: 11 additions & 3 deletions ...t/src/main/java/software/amazon/awssdk/authcrt/signer/internal/SigningConfigProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
public class SigningConfigProvider {

private static final Boolean DEFAULT_DOUBLE_URL_ENCODE = Boolean.TRUE;
private static final Boolean DEFAULT_PATH_NORMALIZATION = Boolean.TRUE;

public SigningConfigProvider() {
}
Expand Down Expand Up @@ -89,13 +90,20 @@ private AwsSigningConfig createPresigningConfig(ExecutionAttributes executionAtt
private AwsSigningConfig createDefaultRequestConfig(ExecutionAttributes executionAttributes) {
AwsSigningConfig signingConfig = createStringToSignConfig(executionAttributes);

signingConfig.setShouldNormalizeUriPath(true);
if (executionAttributes.getAttribute(AwsSignerExecutionAttribute.SIGNER_NORMALIZE_PATH) != null) {
signingConfig.setShouldNormalizeUriPath(
executionAttributes.getAttribute(AwsSignerExecutionAttribute.SIGNER_NORMALIZE_PATH));
} else {
signingConfig.setShouldNormalizeUriPath(DEFAULT_PATH_NORMALIZATION);
}

if (executionAttributes.getAttribute(AwsSignerExecutionAttribute.SIGNER_DOUBLE_URL_ENCODE) != null) {
signingConfig.setUseDoubleUriEncode(executionAttributes
.getAttribute(AwsSignerExecutionAttribute.SIGNER_DOUBLE_URL_ENCODE));
signingConfig.setUseDoubleUriEncode(
executionAttributes.getAttribute(AwsSignerExecutionAttribute.SIGNER_DOUBLE_URL_ENCODE));
} else {
signingConfig.setUseDoubleUriEncode(DEFAULT_DOUBLE_URL_ENCODE);
}

return signingConfig;
}

Expand Down
Loading