Skip to content

Conversation

@haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented Sep 26, 2023

Motivation and Context

  • Since the new signers handle flexible-checksums and aws-chunk coding for unsigned and signed payload cases, we don't need the duplicate logic in HttpChecksumStage
  • However, we still need to support the old path when we are not using new signers

Modifications

  • Add a condition to check if we are using new SRA code, and return early if we are

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@haydenbaker haydenbaker force-pushed the haydenbaker/sra-ia-http-checksum-stage-conditional branch from 17af981 to 5c94941 Compare September 26, 2023 20:29
@haydenbaker haydenbaker force-pushed the haydenbaker/sra-ia-http-checksum-stage-conditional branch from 936735b to beff03b Compare September 27, 2023 21:20
@haydenbaker haydenbaker marked this pull request as ready for review September 27, 2023 21:21
@haydenbaker haydenbaker requested a review from a team as a code owner September 27, 2023 21:21
zoewangg
zoewangg previously approved these changes Sep 27, 2023
return request;
}

// Check for SRA code-path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we'll still need to keep this class to add md5 checksum header (after SRA is fully released)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoewangg zoewangg dismissed their stale review September 28, 2023 00:33

It seems we still need trailer logic from this class, so we probably need to move trailer method up before SRA check

@zoewangg
Copy link
Contributor

Close in favor of #4503

@zoewangg zoewangg closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants