Skip to content

Use HttpChecksumStage for async trailer support #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zoewangg merged 2 commits into from
Sep 28, 2023
Merged

Use HttpChecksumStage for async trailer support #4503

zoewangg merged 2 commits into from
Sep 28, 2023

Conversation

@zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Sep 28, 2023 •
edited
Loading

Motivation and Context

Async signing is not supported in SRA signer at the moment, so we need to rely on existing HttpChecksumStage. Note that for sync, we still use new SRA signer.

Modifications

Use HttpChecksumStage for async trailer support

Testing

Ran AsyncHttpChecksumIntegrationTest and verified it worked.

@zoewangg zoewangg requested a review from a team as a code owner September 28, 2023 20:42
@zoewangg zoewangg mentioned this pull request Sep 28, 2023
Closed
12 tasks
zoewangg
zoewangg commented Sep 28, 2023
View reviewed changes
...rc/it/java/software/amazon/awssdk/services/s3/checksum/AsyncHttpChecksumIntegrationTest.java
* If http is used, payload signing will be enforced, but it's not currently supported in async path
* TODO: re-enable it once it's supported
*/
@Disabled("Payload signing is not supported for S3 async client")
Copy link
Contributor Author

@zoewangg zoewangg Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not supported today. The reason it passes is because payload signing is bypassed (request.contentStreamProvider() == null)

aws-sdk-java-v2/core/auth/src/main/java/software/amazon/awssdk/auth/signer/internal/AbstractAwsS3V4Signer.java

Lines 279 to 285 in 38e221b

private boolean isPayloadSigningEnabled(SdkHttpFullRequest.Builder request, AwsS3V4SignerParams signerParams) {
/**
* If we aren't using https we should always sign the payload unless there is no payload
*/
if (!request.protocol().equals("https") && request.contentStreamProvider() != null) {
return true;
}

cenedhryn
cenedhryn reviewed Sep 28, 2023
View reviewed changes
...c/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/DefaultAwsV4HttpSigner.java
return V4PayloadSigner.create();
}

private static V4PayloadSigner v4PayloadAsyncSigner(
Copy link
Contributor

@cenedhryn cenedhryn Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this makes it clear.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 451 Code Smells

84.2% 84.2% Coverage
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@zoewangg zoewangg merged commit 0b9f12e into feature/master/sra-identity-auth Sep 28, 2023
@zoewangg zoewangg deleted the zoewang/fixAsyncSigning branch September 28, 2023 22:52
@gosar gosar mentioned this pull request Oct 4, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cenedhryn cenedhryn cenedhryn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoewangg @cenedhryn