Minor refacotring to AwsV4HttpSigner impl

[gosar]

Motivation and Context

As I was reading code in this class, as part of debugging something, felt moving some code around made it easier to follow code. And maybe some style guide would recommend public methods earlier.

Modifications

• Move public methods to top of DefaultAwsV4HttpSigner.
• Move some smaller private methods to the end.
• Changed v4PayloadSigner and v4PayloadAsyncSigner parameter to be specific sync/async instead of BaseSignRequest.
• V4Context is not Immutable.
• In test, remove content length from builder instead of signed request.

Testing

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

SonarCloud Quality Gate failed.   

9 Bugs
0 Vulnerabilities
2 Security Hotspots
478 Code Smells

85.1% Coverage
4.2% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[cenedhryn]

Yes, V4Context is a terrible name. I like V4RequestSigningResult or V4RequestSigningOutput

[gosar]

will take up the TODOs separately.

[haydenbaker]

I don't think it needs to be a builder anymore with the payload-signer now having a dedicated method to modify the request that is ran before request-signing.

[gosar]

yup, I noticed later it can be changed, but didn't take that on immediately. It's SdkInternal, so non-blocking, so was planing to address both TODOs later.