Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use exact @aws-sdk/* dependencies #1108

Closed
wants to merge 3 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 26, 2020

Issue #, if available:
Fixes #1072

Description of changes:
uses exact internal dependencies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Search key: "@aws-sdk/([^"]*)": "\^1.0.0-beta.([\d])”
Replace key: "@aws-sdk/$1": "1.0.0-beta.$2"
in package.json
@trivikr
Copy link
Member Author

trivikr commented Apr 26, 2020

Confirmed that integration tests are successful when run locally:

$ yarn && yarn build:all
$ AWS_PROFILE=<teamProfile> yarn test:integration
yarn run v1.22.4
$ cucumber-js --fail-fast
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

153 scenarios (153 passed)
534 steps (534 passed)
1m03.135s
Done in 65.91s.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 38c5492
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Apr 27, 2020

Test publish commit using lerna version --exact trivikr@b18759d

Verified that packages of the versions updated were exact.

Command run for creating GitHub release commit:

./node_modules/lerna/cli.js version --exact --bump prerelease --preid beta --conventional-commits --no-push --no-git-tag-version --no-commit-hooks --yes

@trivikr
Copy link
Member Author

trivikr commented Apr 27, 2020

Succeeded by #1110

@trivikr trivikr closed this Apr 27, 2020
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@trivikr trivikr deleted the exact-dependencies branch June 16, 2020 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-sdk to use exact dependecies for other aws-sdk package dependencies
3 participants