chore(codegen): update to Smithy 1.12.0 #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some malformed request tests are applied to the restJson1 service, which results in unused client commands being generated for the non-server tests, hence the large batch of new files in the aws-restjson protocol tests.
Codecov Report
@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
- Coverage 60.42% 58.57% -1.85%
==========================================
Files 554 558 +4
Lines 28886 30249 +1363
Branches 7072 7443 +371
==========================================
+ Hits 17453 17719 +266
- Misses 11433 12530 +1097
Continue to review full report at Codecov.
|
AllanZhengYP
approved these changes
Oct 7, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to Smithy 1.12.0 to align with the same update in smithy-typescript: smithy-lang/smithy-typescript#448
CI will probably fail until smithy-lang/smithy-typescript#448 has been merged, and will need to be rerun.
Testing
Regenerated protocol tests for client and server locally and ran them, and built the generic client locally as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.