Update to Smithy 1.12.0 #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though smithy-ts technically would move automatically to Smithy 1.12.0, this bumps up the minimum version in order to ensure the new getErrors method on OperationIndex will be available at compile time. Discovery of operation errors globally uses OperationIndex.getErrors(Operation, Service) in order to support service-bound errors, which were introduced in 1.12.0.
AllanZhengYP
approved these changes
Oct 7, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Even though smithy-ts technically would move automatically to Smithy 1.12.0, this bumps up the minimum version in order to ensure the new getErrors method on OperationIndex will be available at compile time. Discovery of operation errors globally uses OperationIndex.getErrors(Operation, Service) in order to support service-bound errors, which were introduced in 1.12.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Even though smithy-ts technically would move automatically to Smithy 1.12.0,
this bumps up the minimum version in order to ensure the new getErrors method
on OperationIndex will be available at compile time. Discovery of operation
errors globally uses OperationIndex.getErrors(Operation, Service) in order
to support service-bound errors, which were introduced in 1.12.0.
Tested this by regenerating the JS SDK v3 and running protocol tests locally. PR for that repo to fast follow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.