Skip to content

chore(deps-dev): bump typscript to v4.6.2 #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 18, 2022

Issue

Fixes: #3217

Description

Bumps typscript to v4.6.2

Testing

Verified that issue in #2754 is not reproducible

  • The dist cjs does have tslib_1.__exportStar(require("./DynamoDBClient"), exports); like in TS 4.3
$ client-dynamodb> cat dist-cjs/index.js
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.DynamoDBServiceException = void 0;
const tslib_1 = require("tslib");
tslib_1.__exportStar(require("./DynamoDB"), exports);
tslib_1.__exportStar(require("./DynamoDBClient"), exports);
tslib_1.__exportStar(require("./commands"), exports);
tslib_1.__exportStar(require("./models"), exports);
tslib_1.__exportStar(require("./pagination"), exports);
tslib_1.__exportStar(require("./waiters"), exports);
var DynamoDBServiceException_1 = require("./models/DynamoDBServiceException");
Object.defineProperty(exports, "DynamoDBServiceException", { enumerable: true, get: function () { return DynamoDBServiceException_1.DynamoDBServiceException; } });
  • The named import works:
import { DynamoDB } from "../aws-sdk-js-v3/clients/client-dynamodb/dist-cjs/index.js";

const region = "us-west-2";

const client = new DynamoDB({ region });
console.log(await client.listTables({}));

Additional Context

This PR will be made ready after karma-typescript bump is merged in #3449


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review March 21, 2022 16:24
@trivikr trivikr requested a review from a team as a code owner March 21, 2022 16:24
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should create a follow-up to remove the useUnknownInCatchVariables tsconfig.

@trivikr trivikr merged commit d430734 into aws:main Mar 21, 2022
@trivikr trivikr deleted the bump-typescript branch March 21, 2022 17:01
@trivikr
Copy link
Member Author

trivikr commented Mar 21, 2022

We should create a follow-up to remove the useUnknownInCatchVariables tsconfig.

Created at #3453

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump TypeScript to 4.6 once it's stable
2 participants