Skip to content

NPM package size #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kirkov opened this issue Feb 11, 2014 · 3 comments
Closed

NPM package size #233

kirkov opened this issue Feb 11, 2014 · 3 comments

Comments

@kirkov
Copy link

kirkov commented Feb 11, 2014

There seems to be a lot of unneeded files downloaded, when installing via npm. The total size is about 15 MB. Perhaps .npmignore https://www.npmjs.org/doc/developers.html#Keeping-files-out-of-your-package ?
@kirkov kirkov mentioned this issue Feb 11, 2014
Closed
@lsegal
Copy link
Contributor

lsegal commented Feb 11, 2014

Thanks for bringing this up. We could certainly ignore some of the API sources. That said, note that the actual download size of the tarball is only 1.9MB, so the actual download is fairly small. It's the disk size that could be improved, but that should not significantly affect install time.

@kirkov
Copy link
Author

kirkov commented Feb 11, 2014

No problem. Yes, you are right, that is fairly small.

@lsegal lsegal closed this as completed in d6d5917 Feb 13, 2014
lsegal added a commit that referenced this issue Mar 26, 2014
@lsegal
Tag release v2.0.0-rc13
150ed59 
References:
  #158, #202, #215, #221, #224, #225, #226, #229, #230, #233,
  #237, #241, #242, #246, #248
lsegal added a commit that referenced this issue Apr 24, 2014
@lsegal
Tag release v2.0.0-rc.14
e66a0bb 
References:
  #158, #202, #215, #221, #224, #225, #226, #229, #230, #233,
  #237, #241, #242, #246, #248
@springmeyer springmeyer mentioned this issue Nov 27, 2014
Merged
@lock
Copy link

lock bot commented Sep 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lsegal @kirkov