Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No compiled JavaScript when installing from Bower #237

Closed
theefer opened this issue Feb 28, 2014 · 4 comments
Closed

No compiled JavaScript when installing from Bower #237

theefer opened this issue Feb 28, 2014 · 4 comments
Labels
feature-request A feature should be added or improved.

Comments

@theefer
Copy link

theefer commented Feb 28, 2014

When installing the 2.0.0-* version using Bower, one gets the original repo with all the sources, tests and build tools, but no compiled (and ideally minimised) package containing all the JS. I know it's possible to use the CDN version instead, but it'd be great it one could import the library using Bower without having to install Ruby to compile it all.

I've resorted to manually downloading the file from the CDN for now.

Note that it's possible to do this without always committing compiled files to the repo by making the Git tags points to a different branch from master that would contain the compiled files. Alternatively, others have spun up a separate repo just for dist files (e.g. Angular).
@lsegal
Copy link
Contributor

lsegal commented Mar 13, 2014

For reference, Ruby is not required to compile the SDK, though node is. That said, I agree that we should find a way to include the built asset available to Bower. We are currently investigating ways to improve the way the SDK is distributed, so I will mark this as a feature suggestion for Bower support.

@lsegal lsegal closed this as completed in 553e9b2 Mar 14, 2014
@lsegal
Copy link
Contributor

lsegal commented Mar 14, 2014

Thanks for reporting. The next release (rc12) will have Bower support via bower install aws-sdk. You can use aws-sdk#master to take a look at how it works now.

@theefer
Copy link
Author

theefer commented Mar 15, 2014

Looks great, thanks!

lsegal added a commit that referenced this issue Mar 26, 2014
@lsegal
Tag release v2.0.0-rc13
150ed59 
References:
  #158, #202, #215, #221, #224, #225, #226, #229, #230, #233,
  #237, #241, #242, #246, #248
lsegal added a commit that referenced this issue Apr 24, 2014
@lsegal
Tag release v2.0.0-rc.14
e66a0bb 
References:
  #158, #202, #215, #221, #224, #225, #226, #229, #230, #233,
  #237, #241, #242, #246, #248
@lock
Copy link

lock bot commented Sep 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lsegal @theefer