Populate User Agent Details #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscpinheiro
requested changes
Mar 31, 2025
sdk/src/Core/Amazon.Runtime/Pipeline/HttpHandler/HttpHandler.cs
Outdated
Show resolved
Hide resolved
sdk/src/Core/Amazon.Runtime/Pipeline/Handlers/BaseEndpointResolver.cs
Outdated
Show resolved
Hide resolved
muhammad-othman
force-pushed
the
muhamoth/DOTNET-7974-Populate-UserAgentDetails
branch
from
17ed221 to
964dff1
Compare
muhammad-othman
force-pushed
the
muhamoth/DOTNET-7974-Populate-UserAgentDetails
branch
from
964dff1 to
0a80cc1
Compare
dscpinheiro
approved these changes
Mar 31, 2025
normj
reviewed
Mar 31, 2025
sdk/src/Core/Amazon.Runtime/CredentialManagement/AWSCredentialsFactory.cs
Show resolved
Hide resolved
sdk/src/Core/Amazon.Runtime/CredentialManagement/AWSCredentialsFactory.cs
Show resolved
Hide resolved
normj
approved these changes
Apr 1, 2025
muhammad-othman
merged commit 081eba1
into
Business-Metrics-Tracking-UA-2.1
2 checks passed
muhammad-othman
deleted the
muhamoth/DOTNET-7974-Populate-UserAgentDetails
branch
muhammad-othman
added a commit
that referenced
this pull request
Apr 3, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added feature IDs to the user agent:
CREDENTIALS_AWS_SDK_STORERESOLVED_ACCOUNT_IDENDPOINT_OVERRIDEACCOUNT_ID_MODE_DISABLEDACCOUNT_ID_MODE_PREFERREDACCOUNT_ID_MODE_REQUIREDSIGV4A_SIGNINGS3_EXPRESS_BUCKETStill missing the following features that were added later to the SEP:
DDB_MAPPERSSO_LOGIN_DEVICESSO_LOGIN_AUTHMotivation and Context
DOTNET-7974Testing
DRY_RUN-bf6c38e1-0972-4fd9-814d-d4a2ad98e183Screenshots (if appropriate)
Types of changes
Checklist
License