Add DDB_MAPPER feature ID for requests originating from DynamoDBContext #3734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
reviewed
Apr 1, 2025
| userAgentDetails.AddUserAgentComponent($"md/{this.TableConsumer}"); | ||
| userAgentDetails.AddUserAgentComponent($"md/{(isAsync ? "TableAsync" : "TableSync")}"); | ||
|
|
||
| if (this.TableConsumer == DynamoDBConsumer.DataModel) |
There was a problem hiding this comment.
Can we add a feature id for the document DynamoDBConsumer?
There was a problem hiding this comment.
Yeah, but we have to add it to the SEP first to book the feature id, otherwise some other team might add the same ID for a different feature.
There was a problem hiding this comment.
I know we need to reserve the feature id but I thought that was just had to ask the metrics team. Hopefully the process for SDK specific features getting their own feature id is light weight.
There was a problem hiding this comment.
I'm not sure what is the process so far, I did reach out to the metrics team but I didn't get a response yet.
dscpinheiro
reviewed
Apr 1, 2025
muhammad-othman
force-pushed
the
muhamoth/DOTNET-7974-DDB-FeatureId
branch
from
f85781f to
0f5a7d4
Compare
dscpinheiro
approved these changes
Apr 1, 2025
normj
approved these changes
Apr 2, 2025
muhammad-othman
merged commit 64e9821
into
Business-Metrics-Tracking-UA-2.1
1 check passed
muhammad-othman
added a commit
that referenced
this pull request
Apr 3, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
DDB_MAPPERfeature ID to the user agent when requests originate fromDynamoDBContext.Motivation and Context
DOTNET-7974Testing
Validated that the requests originated from
DynamoDBContextcontainsDDB_MAPPERfeature ID (d).ft/ddb-hll md/DataModel md/TableSync aws-sdk-dotnet-framework/4.0.0.0 ua/2.1 os/windows lang/.NET_Runtime#4.0 md/.NET_Framework#4.8.09037 md/aws-sdk-dotnet-core#4.0.0.0 api/DynamoDB#4.0.0.0 md/ClientSync cfg/init-coll#0 m/d,b,e,E.Validated that the requests originated from
DocumentModeldoesn't containDDB_MAPPERfeature ID.ft/ddb-hll md/DocumentModel md/TableSync aws-sdk-dotnet-framework/4.0.0.0 ua/2.1 os/windows lang/.NET_Runtime#4.0 md/.NET_Framework#4.8.09037 md/aws-sdk-dotnet-core#4.0.0.0 api/DynamoDB#4.0.0.0 md/ClientSync cfg/init-coll#0 m/b,e,E.DRY_RUN-9eafeef3-1df1-4cd6-a166-a45365593a86Types of changes
Checklist
License