-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] V3 #23
[WIP] V3 #23
Conversation
Hi @jeremeamia I've made progress on it. Here are the few things I've done:
There are a few things I'm a bit unsure, and one test in S3 is failing and I'm not sure how to solve it. From now on I think you can use this version and finish the work :). Have a nice day! |
I also realized that most S3 tests were failing because the generated URLs were completely different (see the diff in tests). I'm not sure if those are a new style of URL in S3. |
'aws_zf2' => [ | ||
'session' => [ | ||
'save_handler' => [ | ||
'dynamodb' => [ | ||
// Locking strategy used for doing session locking. | ||
// 'locking_strategy' => null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 'locking' => false,
now
Looking good. Thanks @bakura10!
We have moved to a more regionalized and secure S3 experience for V3. This means that region must be specified when creating an S3 client, Signature Version 4 is used exclusively for signing requests, and we no longer move bucket names into the host name. |
@jeremamia, I've done the various changes, and changed the namespace to AwsModule. I let you know have a look at it, and fix the missing test for S3 ;). Have a nice day! |
@bakura10 Thanks! |
Is there anything else I can do @jeremeamia ? :) |
Was working on this earlier today. I'll get back to you soon.
|
Closing in favor of #27, which includes these changes. |
This oversedes #22. Sorry I didn't have more time today I'll try to do that tomorrow. This one will also include switch to PSR-4 and min dependency of 5.5