Changes for SDK 3 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@bakura10 I created a 1.2 branch from master, so I think we can merge this into master once Travis builds. Then it would be great if you could help me by testing within a ZF2 app. If that works well and you don't see any other necessary changes, then it will be ready for tagging. |
|
Yep, actually I'm not developing any PHP stuff for now, but I'll download it into a small ZF2 app and try it this week-end. Is that ok for the timing? However I think this should be v2. This is a BC in the dependency. For example SlmQueue depends on Aws module 1.*, which expects SDK v2 factory. Tagging this one v1.2 would break it imho. |
|
Sorry. I mean to make this 2.0. The 1.2 branch is for the current stable version, so I can apply fixes if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes by @bakura10.