feat: Support placeholders for TransformStep #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests pass locally - will need more investigation for throttling issues during build |
evscott
reviewed
Sep 30, 2021
evscott
reviewed
Oct 4, 2021
shivlaks
previously requested changes
Oct 5, 2021
Co-authored-by: Eliot V Scott <eliotvscott@gmail.com> Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
ca-nguyen
dismissed
shivlaks’s stale review
Updated PR per suggestions and addressed comments
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
approved these changes
Oct 16, 2021
evscott
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change being made.
Fixes #117 and #171
Why is the change necessary?
Currently, it is not possible to use placeholders for Sagemaker Transform properties. The properties cannot be defined dynamically, as they need to be defined in the Transformer which does not accept placeholders.
This change makes it possible to use placeholders for Transform properties by using the
parametersfield that are passed down from the TransformStep.Solution
Use the
parametersfield that is compatible with placeholders to define TrainingStep properties.Merge the parameters that were generated from the Transformer with the input parameters:
Testing
Added integration and unit tests
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.