perf(sam): do not watch files excluded in user settings #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
changed the title
justinmk3
commented
Aug 24, 2023
|
/runintegrationtests |
Problem: "Scanning CloudFormation templates..." takes a long time on big workspaces, and there is no workaround. #3510 Solution: When scanning for CFN/SAM templates, exclude all directories/files specified in _all_ of the vscode settings `files.exclude`, `search.exclude`, or `files.watcherExclude`.
Problem:
vscode extension host logs show many warnings like this:
[warning] [amazonwebservices.aws-toolkit-vscode] Accessing a resource scoped configuration without providing a resource is not expected.
To get the effective value for 'files.watcherExclude', provide the URI of a resource or 'null' for any resource
Solution:
Default to `null` instead of `undefined` when getting a config.
Problem:
If a setting value is invalid, `Settings.instance.get` throws an
exception, even if a `defaultValue` is provided. We almost never want
that behavior. Example:
Settings.instance.get<object>('files.exclude', Number, 42)
Solution:
Copy the logic from `AnonymousSettings.get()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
files.exclude,search.exclude, orfiles.watcherExclude.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.